Improve resultSelector documentation for Data Source Bindings#1348
Open
v-schhabra wants to merge 5 commits intomasterfrom
Open
Improve resultSelector documentation for Data Source Bindings#1348v-schhabra wants to merge 5 commits intomasterfrom
v-schhabra wants to merge 5 commits intomasterfrom
Conversation
Added detailed reference section for resultSelector including: - Table of all supported selector types (jsonpath, xpath, none, plaintext) - JSONPath implementation details (Newtonsoft.Json JToken.SelectTokens) - Supported JSONPath operators with examples - XPath implementation details (.NET System.Xml.XPath, XPath 1.0) - Note about automatic namespace removal for XPath - Response size limit documentation Resolves AB#2019941 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
manolerazvan
approved these changes
Apr 16, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
| ``` | ||
|
|
||
| **Notes :** | ||
| - Keep JSONPath expressions simple and easy to understand. |
Contributor
There was a problem hiding this comment.
Vague notes section — These three bullet points under JSONPath Notes are low-signal:
Maybe we should do it more like this:
"The implementation uses Newtonsoft.Json JToken.SelectTokens, which supports most standard JSONPath operators but not script expressions ([?(@.length-1)])."
"If a query returns no results, verify the response structure by using jsonpath:$ to see the full response."
| |--------|-------------| | ||
| | `jsonpath:` | Used to extract data from JSON responses | | ||
| | `xpath:` | Used to extract data from XML responses | | ||
| | `none` | Returns no data | |
Contributor
There was a problem hiding this comment.
replace with "Returns no data from the response"
| ``` | ||
| "resultSelector": "none" | ||
| ``` | ||
| Use when you don't need any data from the response (e.g., for write-only REST calls). |
Contributor
There was a problem hiding this comment.
instead of write-only rest calls - maybe would be better ""(e.g., for POST/PUT calls where only the status code matters)."
manolerazvan
approved these changes
Apr 16, 2026
manolerazvan
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the resultSelector documentation for Data Source Bindings.
Resolves AB#2019941
Description:
Documentation changes required: (Y/N) Yes
Added unit tests: (Y/N) N
Attached related issue: (Y/N) Y
Checklist: